Skip to content

Comments

Remove usage of cache suffix#6054

Merged
AdamGS merged 1 commit intodevelopfrom
adamg/remove-cache-suffix-usage
Jan 20, 2026
Merged

Remove usage of cache suffix#6054
AdamGS merged 1 commit intodevelopfrom
adamg/remove-cache-suffix-usage

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 20, 2026

We don't the cache suffix explicitly anymore as we use the job id as part of the cache key, and it serves the same purpose to the same effect in all the places we added it.

@AdamGS
Remove usage of cache suffix
1b029cb 
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS enabled auto-merge (squash) January 20, 2026 12:29
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 20, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 29.73%

Comparing adamg/remove-cache-suffix-usage (1b029cb) with develop (3388245)

Summary

⚡ 24 improved benchmarks
❌ 9 regressed benchmarks
✅ 1221 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation decompress_bitpacking_early_filter[i16, 0.05] 275.7 µs 233 µs +18.28%
⚡ Simulation decompress_bitpacking_early_filter[i16, 0.04] 258.2 µs 215.6 µs +19.75%
⚡ Simulation decompress_bitpacking_early_filter[i16, 0.03] 241.5 µs 199 µs +21.34%
❌ Simulation patched_take_200k_dispersed 5 ms 5.6 ms -10.2%
⚡ Simulation decompress_bitpacking_late_filter[i16, 0.0105] 200.6 µs 158.1 µs +26.87%
❌ Simulation canonical_into_non_nullable[(10000, 10, 0.1)] 381.3 µs 465.8 µs -18.14%
❌ Simulation canonical_into_non_nullable[(10000, 10, 0.01)] 226.8 µs 311.2 µs -27.13%
❌ Simulation canonical_into_non_nullable[(10000, 10, 0.0)] 199.5 µs 283.9 µs -29.73%
⚡ Simulation canonical_into_nullable[(10000, 10, 0.0)] 526.3 µs 454.6 µs +15.77%
⚡ Simulation decompress_bitpacking_late_filter[i16, 0.03] 235.6 µs 193.1 µs +21.98%
⚡ Simulation decompress_bitpacking_late_filter[i16, 0.04] 252.9 µs 210.6 µs +20.11%
⚡ Simulation decompress_bitpacking_late_filter[i16, 0.02] 218.1 µs 175.6 µs +24.17%
⚡ Simulation decompress_bitpacking_late_filter[i32, 0.01] 299.7 µs 212 µs +41.38%
⚡ Simulation decompress_bitpacking_late_filter[i32, 0.0105] 300.6 µs 212.8 µs +41.23%
❌ Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.3 ms 5.1 ms -15.93%
⚡ Simulation decompress_bitpacking_late_filter[i16, 0.05] 270.3 µs 228 µs +18.53%
⚡ Simulation decompress_bitpacking_late_filter[i32, 0.04] 356.6 µs 268.8 µs +32.67%
⚡ Simulation decompress_bitpacking_late_filter[i32, 0.02] 319.3 µs 231.5 µs +37.88%
⚡ Simulation decompress_bitpacking_late_filter[i32, 0.05] 375.4 µs 287.4 µs +30.6%
⚡ Simulation decompress_bitpacking_late_filter[i32, 0.03] 337.9 µs 250.2 µs +35.06%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codecov
Copy link

codecov bot commented Jan 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.85%. Comparing base (630322d) to head (1b029cb).
⚠️ Report is 2 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robert3005 robert3005 added the changelog/chore A trivial change label Jan 20, 2026
@AdamGS AdamGS merged commit 590119c into develop Jan 20, 2026
47 of 50 checks passed
@AdamGS AdamGS deleted the adamg/remove-cache-suffix-usage branch January 20, 2026 12:37
danking pushed a commit that referenced this pull request Feb 6, 2026
@AdamGS @danking
Remove usage of cache suffix (#6054)
579ba6d 
We don't the cache suffix explicitly anymore as we use the job id as
part of the cache key, and it serves the same purpose to the same effect
in all the places we added it.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robert3005 robert3005 robert3005 approved these changes

@joseph-isaacs joseph-isaacs Awaiting requested review from joseph-isaacs

Assignees

No one assigned

Labels

changelog/chore A trivial change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdamGS @robert3005